mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 30192: Updated RateLimiter to allow discard semantics.
Date Tue, 27 Jan 2015 18:18:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30192/
-----------------------------------------------------------

(Updated Jan. 27, 2015, 6:18 p.m.)


Review request for mesos, Ben Mahler and Jie Yu.


Changes
-------

ben's comments.


Bugs: MESOS-2230
    https://issues.apache.org/jira/browse/MESOS-2230


Repository: mesos-git


Description
-------

I tried/implemented a complex solution involving list iterators and removing discarded promises
from the list, but it was hard to reason about the correctness and race conditions. So abandoned
it in favor of a simpler solution. Let me know what you think.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/limiter.hpp a1c4f189565003f19f8b33c3b8a81e28836069c1

  3rdparty/libprocess/src/tests/limiter_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/30192/diff/


Testing
-------

make check


Thanks,

Vinod Kone


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message