mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kapil Arya" <ka...@mesosphere.io>
Subject Re: Review Request 30048: [Libprocess]: Fix installation path for system installed dependencies.
Date Fri, 23 Jan 2015 22:44:57 GMT


> On Jan. 23, 2015, 5:38 p.m., Timothy St. Clair wrote:
> > 3rdparty/libprocess/configure.ac, line 178
> > <https://reviews.apache.org/r/30048/diff/1/?file=825235#file825235line178>
> >
> >     maybe I'm missing something, but isn't 'test -d' to check directories?

Yeah, that's exactly what we want to test.  The "--with-boost" expects a directory name.


- Kapil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30048/#review69493
-----------------------------------------------------------


On Jan. 19, 2015, 2:32 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30048/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2015, 2:32 p.m.)
> 
> 
> Review request for mesos, Cody Maloney and Timothy St. Clair.
> 
> 
> Bugs: MESOS-2235
>     https://issues.apache.org/jira/browse/MESOS-2235
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> For dependencies, if installation path is not provided, assume system default locations.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/configure.ac 19bc601247f3b1fc6b28d3474fb39f7369bb382f 
> 
> Diff: https://reviews.apache.org/r/30048/diff/
> 
> 
> Testing
> -------
> 
> ../configure --with-protobuf && make 
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message