> On Jan. 23, 2015, 1:26 a.m., Niklas Nielsen wrote:
> > src/master/allocation/allocator.hpp, lines 35-36
> > <https://reviews.apache.org/r/29931/diff/2/?file=826958#file826958line35>
> >
> > Is this still relevant? The allocator only lives in the master and the containerizer
and isolators similarily knows about the slave flags.
> >
> > If not, let's kill the comments referencing the master flags removal
I would argue it's relevant. From the whole collection of master flags we use just one value.
For me, this introduces an unnecessary dependency. I would prefer to have a small structure
that contains value relevant for allocators.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29931/#review69322
-----------------------------------------------------------
On Jan. 20, 2015, 6:16 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29931/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2015, 6:16 p.m.)
>
>
> Review request for mesos, Bernd Mathiske and Niklas Nielsen.
>
>
> Bugs: MESOS-2213
> https://issues.apache.org/jira/browse/MESOS-2213
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/Makefile.am 07bea1f
> src/master/allocation/allocator.hpp PRE-CREATION
> src/master/allocation/mesos/allocator.hpp PRE-CREATION
> src/master/allocation/mesos/hierarchical.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29931/diff/
>
>
> Testing
> -------
>
> make check (Ubuntu, OS X)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
|