mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 30110: Added support for RepeatedPtrField to ::protobuf::write.
Date Thu, 22 Jan 2015 23:32:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30110/#review69299
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp
<https://reviews.apache.org/r/30110/#comment113943>

    I thought the consensus was to have a internal write in src/slave/state.hpp (not here)?


- Jie Yu


On Jan. 22, 2015, 4:52 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30110/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2015, 4:52 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Added support for `RepeatedPtrField` to `::protobuf::write`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 62e72b4b16d0f08cce305e27aa7539970263c4e7

>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp b4f5f172d0ea21fbd56dde1eb43d95f9cddad44b

> 
> Diff: https://reviews.apache.org/r/30110/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message