mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 29918: Introduced a generic checkpoint function.
Date Thu, 22 Jan 2015 04:50:29 GMT


> On Jan. 22, 2015, 1:16 a.m., Jie Yu wrote:
> > src/slave/state.hpp, lines 76-78
> > <https://reviews.apache.org/r/29918/diff/7/?file=828871#file828871line76>
> >
> >     Wrap comment in 70 char width.

Do you mean it's wrapped too early?


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29918/#review69076
-----------------------------------------------------------


On Jan. 21, 2015, 10:08 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29918/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2015, 10:08 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Introduced a generic checkpoint function.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp 7935e7f9bfe66d1900594dcdcb800c4593a3940f 
>   src/slave/state.hpp 70777cf6ab681c29ca4df601fe47903e1dbdf41f 
>   src/slave/state.cpp a36fa53099300ee03f051b0f5eaaafe9f1da68d1 
>   src/tests/slave_recovery_tests.cpp 809822e63b05a21418cd9297c927d656d6fd871d 
> 
> Diff: https://reviews.apache.org/r/29918/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message