mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 30149: mesos: Added O_CLOEXEC flag to os::open calls.
Date Thu, 22 Jan 2015 01:14:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30149/#review69108
-----------------------------------------------------------


Patch looks great!

Reviews applied: [30149]

All tests passed.

- Mesos ReviewBot


On Jan. 21, 2015, 11:52 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30149/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2015, 11:52 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-1432
>     https://issues.apache.org/jira/browse/MESOS-1432
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> mesos: Added O_CLOEXEC flag to os::open calls.
> 
> 
> Diffs
> -----
> 
>   src/files/files.cpp 12e8f75aa7bd77d2e81d5d3a7a4d09dd915854aa 
>   src/linux/cgroups.cpp 62df4b7645c6ab061a47634058d79ca849caa6b9 
>   src/linux/ns.hpp ec1a5171c8923d8661caab9999d0d73d5140bee4 
>   src/slave/containerizer/external_containerizer.cpp efbc68f205b26cff58bc414427d3361711afcc94

>   src/slave/containerizer/fetcher.cpp 5993670f7899233efa1e6acef4b0c7856e32f748 
>   src/tests/credentials_tests.cpp 5878e57650a78777933d6df156df3c12bcfeafb5 
>   src/tests/mesos.cpp 3b98c69a604132be71a60fbbee4a47b51fe6956a 
> 
> Diff: https://reviews.apache.org/r/30149/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message