mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 30006: Enabled concurrent downloading into the fetcher cache
Date Wed, 21 Jan 2015 19:45:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30006/#review68985
-----------------------------------------------------------



src/slave/containerizer/fetcher.cpp
<https://reviews.apache.org/r/30006/#comment113553>

    Can't you directly bind(&collect, pendingDownloads)?



src/slave/containerizer/fetcher.cpp
<https://reviews.apache.org/r/30006/#comment113554>

    Is there anything that expires the cache items?


- Timothy Chen


On Jan. 21, 2015, 10:49 a.m., Bernd Mathiske wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30006/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2015, 10:49 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, and Timothy Chen.
> 
> 
> Bugs: MESOS-2057
>     https://issues.apache.org/jira/browse/MESOS-2057
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Enables reuse of download results in the cache when multiple fetcher runs occur concurrently.
Optimizes for minimal number of fetcher runs, between 0 and 2, depending on what is in the
cache and what can be obtained from concurrent runs by simply waiting for their already initiated
downloads for the same content to complete.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/fetcher.hpp 1db0eaf002c8d0eaf4e0391858e61e0912b35829 
>   src/slave/containerizer/fetcher.cpp 5993670f7899233efa1e6acef4b0c7856e32f748 
> 
> Diff: https://reviews.apache.org/r/30006/diff/
> 
> 
> Testing
> -------
> 
> make check, testing whether legacy direct fetching still works, using existing tests.

> 
> Testing of cache functionality coming in MESOS-2074.
> 
> 
> Thanks,
> 
> Bernd Mathiske
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message