mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Review Request 29569: Refactored Once abstraction to not use Promise.
Date Wed, 21 Jan 2015 17:54:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29569/
-----------------------------------------------------------

Review request for mesos, Joris Van Remoortere and Niklas Nielsen.


Repository: mesos-git


Description
-------

The original once abstraction was implemented using promises, which made it unusable to initialize
libprocess because libprocess must be initialized in order to use a Promise. This removes
that requirement, but it also means that an actor blocking on a Once will no longer donate
it's thread while it's waiting (since it doesn't wait on a Promise, which waits on a Latch,
which waits on a ProcessBase, which donates the thread while waiting).


Diffs
-----

  3rdparty/libprocess/include/process/once.hpp e85b38205065b34d438f68a6441905eb2f90169c 

Diff: https://reviews.apache.org/r/29569/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message