mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <be...@mesosphere.io>
Subject Re: Review Request 30037: Introduced fetcher cache actions
Date Wed, 21 Jan 2015 08:54:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30037/
-----------------------------------------------------------

(Updated Jan. 21, 2015, 12:54 a.m.)


Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and Timothy Chen.


Changes
-------

3rd time should be a charm. This patch should show no diff since the revision after the most
recent review comments. The only difference is that it should be applicable after its parent
changed.


Bugs: MESOS-2069
    https://issues.apache.org/jira/browse/MESOS-2069


Repository: mesos-git


Description
-------

Extends the fetcher info protobuf with "actions" (fetch directly, through cache, retrieve
from cache). Switches the basis for dealing with uris to "items", which contain the uri, the
action, and potentially and cache file name. Refactors fetch() and run(), so there is only
one of each. Introduces about half of the actual cache logic, including a hashmap of cache
file objects for bookkeeping and basic operations on it. 


Diffs (updated)
-----

  include/mesos/fetcher/fetcher.proto facb87b92bf3194516f636dcc348e136af537721 
  src/launcher/fetcher.cpp fed0105946da579a38357a30e7ae56e646e05b89 
  src/slave/containerizer/fetcher.hpp 1db0eaf002c8d0eaf4e0391858e61e0912b35829 
  src/slave/containerizer/fetcher.cpp 5993670f7899233efa1e6acef4b0c7856e32f748 

Diff: https://reviews.apache.org/r/30037/diff/


Testing
-------

make check


Thanks,

Bernd Mathiske


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message