mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niklas Nielsen" <...@qni.dk>
Subject Re: Review Request 29781: Exposed type_utils.hpp as include/mesos/type_utils.hpp.
Date Wed, 21 Jan 2015 00:16:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29781/#review68810
-----------------------------------------------------------


Can you expand a bit on why you needed to move this out too?


src/common/type_utils.hpp
<https://reviews.apache.org/r/29781/#comment113287>

    Let's get 'pragma once' approved and in the style guide before pushing any code that uses
it.


- Niklas Nielsen


On Jan. 19, 2015, 2:52 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29781/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2015, 2:52 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-2096
>     https://issues.apache.org/jira/browse/MESOS-2096
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> [4/10] Build Mesos Modules outside Mesos source tree.
> 
> This file includes definitions for operators on public protobufs
> (defined in mesos.proto) that don't have these operators generated
> by the protobuf compiler.  The corresponding definitions are in
> src/common/type_utils.cpp.
> 
> Mesos modules need some of the protobufs defined in mesos.proto and
> require some of these operators declared in type_utils.hpp. Exposing
> type_utils.hpp allows us to build modules without having a dependency
> on mesos source tree (src/*).
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e 
>   src/cli/execute.cpp 77deec91177c90a8a20ccd4fe063b82ca08cefbd 
>   src/common/protobuf_utils.cpp c4b53a81c0426d361363c12920d67c261e381553 
>   src/common/type_utils.hpp 2d22db85f87ec5c1134208aae5b2105d2d267000 
>   src/common/type_utils.cpp fcc9eb0e27a9cbf53f7923f0c051a6578527ec37 
>   src/examples/low_level_scheduler_libprocess.cpp a0ec131fff1773280b17e97cb78a3da88afe6f7d

>   src/examples/low_level_scheduler_pthread.cpp f05489ae10032dcf177ce149938cd94186355351

>   src/examples/no_executor_framework.cpp 5e47cfcfa1677052be114f8a9b0e24f6ef0238d9 
>   src/examples/test_framework.cpp e5ec3b9f75446980ce9235209b8b74128e3e5e39 
>   src/exec/exec.cpp aada24664dba9060a92230e25689c89852585443 
>   src/launcher/executor.cpp d527fec3b9e658099571f808aa824bd6e17a6e0d 
>   src/log/coordinator.cpp fe0c5f9c55fd7a19b9c85a0860f88dd14205a631 
>   src/log/recover.cpp 679741b843a1df112090cd2ce2b1bc20abbbcf44 
>   src/log/replica.cpp dedfde4eebc12c6c4d1e75fe1f6751a56324688a 
>   src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8 
>   src/master/master.hpp a8ce4d023ddea36cb83a2dc7b95abd12342f345a 
>   src/master/registrar.cpp 0831963e01e3c87bf0ac27af24b832ab2ae09d97 
>   src/sched/sched.cpp a822c002781b35872d3c477366775a3705343cd2 
>   src/scheduler/scheduler.cpp 44713cae36a83081c9a665d2eb73f9dbec2d4268 
>   src/slave/containerizer/external_containerizer.cpp efbc68f205b26cff58bc414427d3361711afcc94

>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 90aabb85da452a3a508888f738379a73b7465dc6

>   src/slave/containerizer/isolators/cgroups/mem.cpp 711d66d7771cac13be831d73af3ef570d6785473

>   src/slave/http.cpp d1cf8a68fab9a2df44f6c753683ad37fd4b1a1f9 
>   src/slave/monitor.hpp f4ebafc5bbba43669dc1436899072b009936a22e 
>   src/slave/paths.cpp fe951abac1254748dbd5bdd81b7e50da75afad6d 
>   src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6 
>   src/slave/slave.cpp fca83b3977b95ddda30f9830da10e124b5c605e6 
>   src/slave/state.hpp 70777cf6ab681c29ca4df601fe47903e1dbdf41f 
>   src/slave/status_update_manager.hpp 1c8a54ea510de084c0f35016e83788d441d3b813 
>   src/tests/flags.hpp 0d3db6cd13b898674e7e62ce90543c5834225294 
>   src/tests/protobuf_io_tests.cpp c18bc4f8d342f6a8cbe7ca09fe2bc25f215d8249 
>   src/tests/registrar_tests.cpp 6bfb679d6ab07143f9c77b8cd9719a36d363645f 
>   src/tests/state_tests.cpp ef2e96fb8b3a5e3b9c3c045b22f43f818d327b9e 
> 
> Diff: https://reviews.apache.org/r/29781/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message