mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <a...@mesosphere.io>
Subject Re: Review Request 29927: Implemented MasterAllocatorTest::StopAllocator() method.
Date Tue, 20 Jan 2015 18:10:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29927/
-----------------------------------------------------------

(Updated Jan. 20, 2015, 6:10 p.m.)


Review request for mesos, Bernd Mathiske and Niklas Nielsen.


Changes
-------

Change the way a test can stop allocator.


Summary (updated)
-----------------

Implemented MasterAllocatorTest::StopAllocator() method.


Bugs: MESOS-2213
    https://issues.apache.org/jira/browse/MESOS-2213


Repository: mesos-git


Description (updated)
-------

Several tests have been reported flaky if allocation is not ceased explicitly (see MESOS-1677).
To stop allocation, an allocator instance should be destroyed. To facilitate this, store a
pointer to a MockAllocator instance in the MasterAllocatorTest fixture and let a test case
destroy it.


Diffs (updated)
-----

  src/tests/master_allocator_tests.cpp 2430622 

Diff: https://reviews.apache.org/r/29927/diff/


Testing
-------

make check (Ubuntu, OS X)


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message