mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 29329: Add executor for docker containerizer
Date Sat, 17 Jan 2015 01:39:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29329/#review68533
-----------------------------------------------------------


How are we going to manage the duplication across the command executor and the docker executor?


src/docker/executor.cpp
<https://reviews.apache.org/r/29329/#comment112834>

    Just passing by, this says the executor launches the container, but below it just looks
like it waits for it to terminate via `docker wait`, or am I missing something?



src/docker/executor.cpp
<https://reviews.apache.org/r/29329/#comment112833>

    Probably warrants a comment, what does `"exit `...`" do?`


- Ben Mahler


On Jan. 17, 2015, 1:26 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29329/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2015, 1:26 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Bernd Mathiske.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Add executor for docker containerizer, replaces the usage of command executor
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 07bea1f 
>   src/docker/executor.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/29329/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message