mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 29896: Added a slave flag to turn off disk quota enforcement.
Date Sat, 17 Jan 2015 00:18:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29896/#review68512
-----------------------------------------------------------


Thanks!

Let's try to avoid the flag ambiguity and clean up the help messages, see below:


src/slave/flags.hpp
<https://reviews.apache.org/r/29896/#comment112810>

    Let's clarify this one:
    
    For example:
    "... to check the overall disk usage managed by the slave, this drives the garbage collection
of archived information and sandboxes."



src/slave/flags.hpp
<https://reviews.apache.org/r/29896/#comment112807>

    Whould we call this `--container_disk_watch_interval`?
    
    Still a bit concerned about the confusion with `--disk_watch_interval` which we can't
change easily. Ideally we could also change it to `--gc_disk_watch_interval`.



src/slave/flags.hpp
<https://reviews.apache.org/r/29896/#comment112808>

    How about `--enforce_container_disk_quota`?



src/slave/flags.hpp
<https://reviews.apache.org/r/29896/#comment112809>

    enforcement for containers



src/tests/disk_quota_tests.cpp
<https://reviews.apache.org/r/29896/#comment112811>

    Why 100 if you're collecting it every 1 millisecond?
    
    You might want to have an elapsed limit here, so this doesn't run forever?
    
    Here is an example:
    
    https://github.com/apache/mesos/blob/0.21.1/src/tests/cgroups_tests.cpp#L926


- Ben Mahler


On Jan. 16, 2015, 11:52 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29896/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2015, 11:52 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
> 
> 
> Bugs: MESOS-1588
>     https://issues.apache.org/jira/browse/MESOS-1588
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Added a slave flag to turn off disk quota enforcement.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolators/posix/disk.cpp fcadd780f9d417f7422080a03cfbfc2e4d15f1b3

>   src/slave/flags.hpp a4498e6573758642ed8ba28d6a1d228b91c4f2d4 
>   src/tests/disk_quota_tests.cpp 4d23d97b5636bdc447c79e37b3b1b1402068b20e 
> 
> Diff: https://reviews.apache.org/r/29896/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message