mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 28656: Added environment decorator for Slave.
Date Thu, 15 Jan 2015 22:28:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28656/#review68335
-----------------------------------------------------------



src/slave/slave.cpp
<https://reviews.apache.org/r/28656/#comment112519>

    Why pull this into a static method instead of doing it inline?
    
    Also, shouldn't this be guarded by 'flags.hooks.isSome()' ?


- Vinod Kone


On Jan. 14, 2015, 1:31 a.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28656/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2015, 1:31 a.m.)
> 
> 
> Review request for mesos and Niklas Nielsen.
> 
> 
> Bugs: MESOS-2060
>     https://issues.apache.org/jira/browse/MESOS-2060
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Similar to label decorator for Master.
> 
> 
> Diffs
> -----
> 
>   src/hook/hook.hpp PRE-CREATION 
>   src/hook/manager.hpp PRE-CREATION 
>   src/hook/manager.cpp PRE-CREATION 
>   src/slave/flags.hpp f1b8dfbb7391167b67a9498561742aa9ab9089a6 
>   src/slave/main.cpp 2ff2b0d186dd63e1437956e98e3682d83f2f5cd6 
>   src/slave/slave.cpp b234f5359a91a293b93f97f035b08ef0a4c9b20d 
> 
> Diff: https://reviews.apache.org/r/28656/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message