mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 29918: Introduced checkpoint function for Resources.
Date Thu, 15 Jan 2015 19:56:10 GMT


> On Jan. 15, 2015, 7:07 p.m., Jie Yu wrote:
> >

Also, can you follow BenM's comment in r28809 and create a ticket to capture the TODO. I am
wondering if we end up using two files to solve the TODO, what the interface should be? Maybe
we should call it state::update(path, resources)? Any thoughts?


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29918/#review68286
-----------------------------------------------------------


On Jan. 15, 2015, 6:30 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29918/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2015, 6:30 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Introduced checkpoint function for Resources.
> 
> 
> Diffs
> -----
> 
>   src/slave/state.hpp 70777cf6ab681c29ca4df601fe47903e1dbdf41f 
>   src/slave/state.cpp a36fa53099300ee03f051b0f5eaaafe9f1da68d1 
>   src/tests/slave_recovery_tests.cpp 809822e63b05a21418cd9297c927d656d6fd871d 
> 
> Diff: https://reviews.apache.org/r/29918/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message