mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kapil Arya" <ka...@mesosphere.io>
Subject Re: Review Request 29496: Added example hook module.
Date Tue, 13 Jan 2015 18:46:20 GMT


> On Jan. 6, 2015, 8:55 a.m., Niklas Nielsen wrote:
> > src/examples/test_hook_module.cpp, lines 38-40
> > <https://reviews.apache.org/r/29496/diff/1/?file=803967#file803967line38>
> >
> >     I wonder if we can consolidate these strings with the ones in the test code.
Have you tried to extern them from the test and grab them here?

The strings are defined in two separate objects and it's not trivial to share them.  Especially,
when we want to test loading one object without necessarily using the other.  However, I have
now added a comment about the source and that these should be kept in sync.


> On Jan. 6, 2015, 8:55 a.m., Niklas Nielsen wrote:
> > src/tests/hook_tests.cpp, lines 117-118
> > <https://reviews.apache.org/r/29496/diff/1/?file=803968#file803968line117>
> >
> >     I am not sure I understand why you are doing this. Can you expand a little bit?

We need to read the taskInfo to verify the presence of labels inserted by the label decorator
hook.


- Kapil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29496/#review66823
-----------------------------------------------------------


On Jan. 13, 2015, 1:37 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29496/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2015, 1:37 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2060
>     https://issues.apache.org/jira/browse/MESOS-2060
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This module provides hooks for master label decorator, slave executor environment decorator
and slave remove executor.  A couple of test cases are also provided to verify the hooks from
this module.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am fc0c3227466ccf364353a739fec8d9532ea3c683 
>   src/examples/test_hook_module.cpp PRE-CREATION 
>   src/tests/hook_tests.cpp PRE-CREATION 
>   src/tests/module.hpp bc1a37df7f95e945363418429fef4d090907c73a 
>   src/tests/module.cpp 6cec1cbafe4750cff005191c51ce7c08149c18f4 
> 
> Diff: https://reviews.apache.org/r/29496/diff/
> 
> 
> Testing
> -------
> 
> make  check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message