mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 29823: Added accept offers to the old scheduler API.
Date Mon, 12 Jan 2015 23:29:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29823/#review67738
-----------------------------------------------------------

Ship it!


Mind clarifying that it's the just the C++ API in your review summary / commit message?


src/sched/sched.cpp
<https://reviews.apache.org/r/29823/#comment111829>

    "not been" or just "acceptOffers is unimplemented"
    
    Looksl like we should call error here?
    
    ```
    LOG(ERROR) << "acceptOffers is unimplemented";
    error("acceptOffers is unimplemented");
    ```


- Ben Mahler


On Jan. 12, 2015, 9:42 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29823/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2015, 9:42 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Added accept offers to the old scheduler API.
> 
> 
> Diffs
> -----
> 
>   include/mesos/scheduler.hpp 42e4e279d059801cd85955fd04995b60051a2b5e 
>   src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1 
> 
> Diff: https://reviews.apache.org/r/29823/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message