mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kapil Arya" <ka...@mesosphere.io>
Subject Re: Review Request 29780: Moved operators for internal protobufs to messages/messages.hpp.
Date Sat, 10 Jan 2015 07:29:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29780/#review67582
-----------------------------------------------------------



src/slave/state.cpp
<https://reviews.apache.org/r/29780/#comment111628>

    This file was indirectly including messages.hpp earlier.  Due to updated type_utils.hpp,
we need to include "messages.hpp" directly here.


- Kapil Arya


On Jan. 10, 2015, 2:28 a.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29780/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2015, 2:28 a.m.)
> 
> 
> Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-2096
>     https://issues.apache.org/jira/browse/MESOS-2096
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> [3/10] Build Mesos Modules outside Mesos source tree.
> 
> This allows type_utils.hpp to have operators corresponding to
> public protobufs defined in mesos.proto only.  This change
> prepares us to move type_utils.hpp to include/mesos/ as a public
> header.
> 
> 
> Diffs
> -----
> 
>   src/common/type_utils.hpp 2d22db85f87ec5c1134208aae5b2105d2d267000 
>   src/common/type_utils.cpp fcc9eb0e27a9cbf53f7923f0c051a6578527ec37 
>   src/messages/messages.hpp 77840bc6a7dfac7ff17ae11f247a3f77d055b481 
>   src/slave/state.cpp 9de381528fc320fbbfb662325a1275f0b457225b 
>   src/tests/registrar_tests.cpp 6bfb679d6ab07143f9c77b8cd9719a36d363645f 
> 
> Diff: https://reviews.apache.org/r/29780/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message