mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 29690: Added an integration test for enforcing disk quota.
Date Fri, 09 Jan 2015 22:05:06 GMT


> On Jan. 8, 2015, 8:10 p.m., Timothy Chen wrote:
> > src/tests/disk_quota_tests.cpp, line 164
> > <https://reviews.apache.org/r/29690/diff/1/?file=810333#file810333line164>
> >
> >     ah, the disk:1.
> >     It's hard to tell what the units is from that, I wonder if it will be clear
if you add a more descriptive amount in comment. Just a sugggestion :)

Added a comment.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29690/#review67283
-----------------------------------------------------------


On Jan. 8, 2015, 12:45 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29690/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2015, 12:45 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Ian Downes.
> 
> 
> Bugs: MESOS-1588
>     https://issues.apache.org/jira/browse/MESOS-1588
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Added an integration test for enforcing disk quota.
> 
> 
> Diffs
> -----
> 
>   src/tests/disk_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/29690/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message