mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 28562: Added a function to get persistent volume paths.
Date Thu, 08 Jan 2015 22:24:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28562/#review67306
-----------------------------------------------------------

Ship it!


This was my bad, I should have added to paths_tests.cpp for the listing helpers I added. Might
want to add a test in path_tests.cpp for this one.


src/slave/paths.hpp
<https://reviews.apache.org/r/28562/#comment111302>

    Just curious, volumes or persistent volumes? Would we be storing ephemeral volumes in
a similar way?



src/slave/paths.hpp
<https://reviews.apache.org/r/28562/#comment111303>

    Do we restrict the character space of roles? If not, mind filing a ticket now that we're
using them for directory names?


- Ben Mahler


On Jan. 8, 2015, 10:18 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28562/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2015, 10:18 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-2031
>     https://issues.apache.org/jira/browse/MESOS-2031
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Added a function to get persistent volume paths.
> 
> 
> Diffs
> -----
> 
>   src/slave/paths.hpp 8378a51c07d4d82112a274a16441278c90cbe4d5 
>   src/slave/paths.cpp edd801134505568870023b761e034d962808a62f 
> 
> Diff: https://reviews.apache.org/r/28562/diff/
> 
> 
> Testing
> -------
> 
> Will be in subsequent patches.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message