mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Downes" <ian.dow...@gmail.com>
Subject Re: Review Request 29689: Added tests for verifying DiskUsageChecker.
Date Thu, 08 Jan 2015 19:40:45 GMT


> On Jan. 8, 2015, 11:40 a.m., Ian Downes wrote:
> > src/tests/disk_quota_tests.cpp, line 41
> > <https://reviews.apache.org/r/29689/diff/1/?file=810332#file810332line41>
> >
> >     Suggest adding the following tests:
> >     1) Test that an empty directory is > 0
> >     [root@hostname test]# ls -la
> >     total 8
> >     drwxr-xr-x. 2 root    root     4096 Jan  8 19:31 .
> >     drwxr-xr-x. 5 idownes employee 4096 Jan  8 19:31 ..
> >     [root@hostname test]# du -k -s
> >     4       .
> >     
> >     2) Test that a directory with empty files is > 0
> >     
> >     3) Test that a job that exceeds the quota causes a Limitation and the MesosContainerizer
acts upon it.

Oops, missed seeing (3) from the next review, ignore.


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29689/#review67263
-----------------------------------------------------------


On Jan. 7, 2015, 4:45 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29689/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2015, 4:45 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Ian Downes.
> 
> 
> Bugs: MESOS-1588
>     https://issues.apache.org/jira/browse/MESOS-1588
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Added tests for verifying DiskUsageChecker.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 0521f5849acc3237a8fa3970c983beab74441586 
>   src/tests/disk_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/29689/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message