mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 29688: Added DiskQuotaIsolator to enforce disk quota.
Date Thu, 08 Jan 2015 18:27:11 GMT


> On Jan. 8, 2015, 7:59 a.m., Timothy Chen wrote:
> > src/slave/containerizer/isolators/disk_quota.cpp, line 386
> > <https://reviews.apache.org/r/29688/diff/1/?file=810272#file810272line386>
> >
> >     I think one problem that I hit in when reading docker ps output through io:read,
was that the docker ps stdout exceeded the buffer size and s.get().status() is stuck forever
since waitpid never succeeds as the process was waiting for a reader forever.
> >     
> >     du -k -a depending on how many files are in the path I'm thinking potentially
can also have a large output, so I think we should consider reading stdout early.
> 
> Jie Yu wrote:
>     I don't think it's a problem here because I used 'du -k -s' which only prints one
line.

Ah I thought it's -k -a, my bad!


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29688/#review67176
-----------------------------------------------------------


On Jan. 8, 2015, 12:45 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29688/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2015, 12:45 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Ian Downes.
> 
> 
> Bugs: MESOS-1588
>     https://issues.apache.org/jira/browse/MESOS-1588
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Added DiskQuotaIsolator to enforce disk quota. I created a DiskUsageChecker to check
disk usage by calling 'du'. The DiskUsageChecker is throttled (see comments). The isolator
uses DiskUsageChecker to enforce disk quota.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 0521f5849acc3237a8fa3970c983beab74441586 
>   src/slave/containerizer/isolators/disk_quota.hpp PRE-CREATION 
>   src/slave/containerizer/isolators/disk_quota.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/containerizer.cpp 5c014ebe360b9527b3edd505d47e57a4d5ce5c52

> 
> Diff: https://reviews.apache.org/r/29688/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message