mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 29689: Added tests for verifying DiskUsageChecker.
Date Thu, 08 Jan 2015 18:13:37 GMT


> On Jan. 8, 2015, 8:03 a.m., Timothy Chen wrote:
> > src/tests/disk_quota_tests.cpp, line 55
> > <https://reviews.apache.org/r/29689/diff/1/?file=810332#file810332line55>
> >
> >     Why would this be less?

This is a bit tricky because some file system might use more blocks to keep meta data. I don't
want to be over restrictive.

(BTW, on the system I've tested, the size if actually 8192B).


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29689/#review67177
-----------------------------------------------------------


On Jan. 8, 2015, 12:45 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29689/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2015, 12:45 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Ian Downes.
> 
> 
> Bugs: MESOS-1588
>     https://issues.apache.org/jira/browse/MESOS-1588
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Added tests for verifying DiskUsageChecker.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 0521f5849acc3237a8fa3970c983beab74441586 
>   src/tests/disk_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/29689/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message