mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 29556: Send health state in TaskStatus during reconciliation if known
Date Tue, 06 Jan 2015 06:47:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29556/#review66795
-----------------------------------------------------------



src/common/protobuf_utils.hpp
<https://reviews.apache.org/r/29556/#comment110417>

    This seems like you can just declare the function in cpp without adding it in the headers,
but this is fine with me too.



src/tests/health_check_tests.cpp
<https://reviews.apache.org/r/29556/#comment110415>

    Probably leave a comment why you choose to put TASK_KILLED here.



src/tests/health_check_tests.cpp
<https://reviews.apache.org/r/29556/#comment110416>

    I think leaving a comment about the implicit vs explicit is a good idea, as it's not obvious
what's going on


- Timothy Chen


On Jan. 6, 2015, 6:13 a.m., Connor Doyle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29556/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2015, 6:13 a.m.)
> 
> 
> Review request for mesos, Adam B and Timothy Chen.
> 
> 
> Bugs: MESOS-2206
>     https://issues.apache.org/jira/browse/MESOS-2206
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Task statuses sent to the framework scheduler from the master do not include a value
for the `healthy` field. The result is that the scheduler is left with incomplete knowledge
about the health state of running tasks indefinitely, until by chance the executor sends a
new status update.
> 
> - Update the createTaskStatus auxilliary function in protobuf utils to take an optional
health flag.
> - Pass known health to createTaskStatus during implicit and explicit task reconciliation.
> 
> 
> Diffs
> -----
> 
>   src/common/protobuf_utils.hpp e42aaa5 
>   src/common/protobuf_utils.cpp 8ab5cdd 
>   src/master/master.cpp d6651e2 
>   src/tests/health_check_tests.cpp a707398 
> 
> Diff: https://reviews.apache.org/r/29556/diff/
> 
> 
> Testing
> -------
> 
> - make
> - make check
> 
> Modified one of the health check tests to ensure that the TaskStatus induced by implicit
and explicit reconciliation have the health field set properly.
> 
> Manual testing using a development branch of the Marathon[1] framework:
> 
> - Launched two tasks with health checks.
> - Waited for both tasks to enter the running state.
> - Waited for both tasks to report healthy.
> - Shut down the scheduler.
> - Re-started (re-registered) the scheduler.
> - Observed indeterminate health state for both tasks as reported by the framework.
> - Waited for the framework to initiate task reconciliation.
> - Observed a TaskStatus with the healthy field set to `true` for both tasks.
> 
> [1] http://github.com/mesosphere/marathon
> 
> 
> Thanks,
> 
> Connor Doyle
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message