mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kapil Arya" <ka...@mesosphere.io>
Subject Re: Review Request 29551: Added "tests" target for make.
Date Mon, 05 Jan 2015 19:10:01 GMT


> On Jan. 5, 2015, 12:18 p.m., Dominic Hamon wrote:
> > Nice idea, but you can already do this using "make check GTEST_FILTER=''". I'm unsure
of the benefit of the extra overhead to enable another way to do the same thing.
> 
> Cody Maloney wrote:
>     Not much code, there is runtime / developer slow down overhead in GTEST_FILTER (not
documented, build test groups in clusters, just running the constructors/destructors around
the tests takes a bit). I can also break the GTEST_FILTER setup (I can add a destructor to
a test which will generate SIGSEGV and break a "make check GTEST_FILTER=''" even though tests
compile).
>     
>     This should enable parallelizing building all the tests in mesos rather than doing
them in chunks which should make things go quicker when I just want to verify the tests build.
Also makes it easier to seperate automated builder failure states without relying on undocumented
/ non-explicit behavior (compiling core, compiling tests, running tests)

+1 for everything Cody wrote.


- Kapil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29551/#review66662
-----------------------------------------------------------


On Jan. 2, 2015, 7:15 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29551/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2015, 7:15 p.m.)
> 
> 
> Review request for mesos and Cody Maloney.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> 'make check' allows one to build and run the test suite. However,
> 'make tests' allows one to build the test suite without running it.
> 
> 
> Diffs
> -----
> 
>   Makefile.am dcd0cb474944ae9c882e6cbdb64a33b4be5b9083 
>   configure.ac acc685caa47717f0fb61a7c18572d7b763ec707b 
>   src/Makefile.am 0521f5849acc3237a8fa3970c983beab74441586 
> 
> Diff: https://reviews.apache.org/r/29551/diff/
> 
> 
> Testing
> -------
> 
> Ran 'make tests'.
> 
> For added test, ran "make clean; make; make tests" followed by "make check" and verified
that no additional target are build in the "make check" step.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message