mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dominic Hamon" <dha...@twopensource.com>
Subject Re: Review Request 29528: Added std::string overloads of Socket::recv/send.
Date Mon, 05 Jan 2015 18:01:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29528/#review66671
-----------------------------------------------------------



3rdparty/libprocess/include/process/socket.hpp
<https://reviews.apache.org/r/29528/#comment110252>

    from experience, this is a potential source of bugs due to strings being NULL terminated.
Ie, if someone tries to use this overload to send arbitrary bytes that contain a \0, it will
be truncated.



3rdparty/libprocess/src/socket.cpp
<https://reviews.apache.org/r/29528/#comment110254>

    given this is being passed internally to this file, could this be a good use of unique_ptr?


- Dominic Hamon


On Jan. 1, 2015, 8:46 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29528/
> -----------------------------------------------------------
> 
> (Updated Jan. 1, 2015, 8:46 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e

>   3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f 
> 
> Diff: https://reviews.apache.org/r/29528/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message