Return-Path: 
 <dev-return-36696-apmail-mesos-dev-archive=mesos.apache.org@mesos.apache.org>
X-Original-To: apmail-mesos-dev-archive@www.apache.org
Delivered-To: apmail-mesos-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id B529E10177
	for <apmail-mesos-dev-archive@www.apache.org>;
 Wed, 31 Dec 2014 08:04:19 +0000 (UTC)
Received: (qmail 98804 invoked by uid 500); 31 Dec 2014 08:04:20 -0000
Delivered-To: apmail-mesos-dev-archive@mesos.apache.org
Received: (qmail 98733 invoked by uid 500); 31 Dec 2014 08:04:20 -0000
Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@mesos.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@mesos.apache.org>
List-Post: <mailto:dev@mesos.apache.org>
List-Id: <dev.mesos.apache.org>
Reply-To: dev@mesos.apache.org
Delivered-To: mailing list dev@mesos.apache.org
Received: (qmail 98710 invoked by uid 99); 31 Dec 2014 08:04:17 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Dec 2014 08:04:17 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 5B2301CA91A;
	Wed, 31 Dec 2014 08:04:16 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============5867104810399470250=="
MIME-Version: 1.0
Subject: Re: Review Request 28698: Modified Resources to account for
 reservation type.
From: "Adam B" <adam@mesosphere.io>
To: "Benjamin Hindman" <benh@berkeley.edu>, "Adam B" <adam@mesosphere.io>,
 "Jie Yu" <yujie.jay@gmail.com>, "Ben Mahler" <benjamin.mahler@gmail.com>,
 "Vinod Kone" <vinodkone@gmail.com>
Cc: "mesos" <dev@mesos.apache.org>, "Michael Park" <mcypark@gmail.com>
Date: Wed, 31 Dec 2014 08:04:16 -0000
Message-ID: <20141231080416.31226.75148@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
Auto-Submitted: auto-generated
Sender: "Adam B" <noreply@reviews.apache.org>
X-ReviewGroup: mesos
X-ReviewRequest-URL: https://reviews.apache.org/r/28698/
X-Sender: "Adam B" <noreply@reviews.apache.org>
References: <20141231000446.31226.6976@reviews.apache.org>
In-Reply-To: <20141231000446.31226.6976@reviews.apache.org>
Reply-To: "Adam B" <adam@mesosphere.io>
X-ReviewRequest-Repository: mesos-git

--===============5867104810399470250==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28698/#review66453
-----------------------------------------------------------

Ship it!


LGTM


src/common/resources.cpp
<https://reviews.apache.org/r/28698/#comment110014>

    s/Donee/Donut/ or whatever.


- Adam B


On Dec. 30, 2014, 4:04 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28698/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2014, 4:04 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Modified Resources to account for reservation type.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp f1517b73def9aff4039f95a89f66208ba1d21c0f 
>   src/common/resources.cpp c17e1791130e7d545bb7cdd54d97d65325d3a69e 
> 
> Diff: https://reviews.apache.org/r/28698/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Michael Park
> 
>


--===============5867104810399470250==--