Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============1941298270215805737=="
MIME-Version: 1.0
Subject: Re: Review Request 28698: [WIP] Modified Resources to account for
 reservation type.
From: "Michael Park" <mcypark@gmail.com>
To: "Benjamin Hindman" <benh@berkeley.edu>, "Adam B" <adam@mesosphere.io>,
 "Jie Yu" <yujie.jay@gmail.com>, "Ben Mahler" <benjamin.mahler@gmail.com>,
 "Vinod Kone" <vinodkone@gmail.com>
Cc: "mesos" <dev@mesos.apache.org>, "Michael Park" <mcypark@gmail.com>
Date: Tue, 30 Dec 2014 22:11:21 -0000
Message-ID: <20141230221121.31226.85243@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Michael Park" <noreply@reviews.apache.org>
References: <20141219020501.12935.31162@reviews.apache.org>
In-Reply-To: <20141219020501.12935.31162@reviews.apache.org>
Reply-To: "Michael Park" <mcypark@gmail.com>

--===============1941298270215805737==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Dec. 19, 2014, 2:05 a.m., Adam B wrote:
> > include/mesos/resources.hpp, lines 64-69
> > <https://reviews.apache.org/r/28698/diff/2/?file=793361#file793361line64>
> >
> >     Does this always assume STATIC? Shouldn't you be able to parse a string into name/value/role while also specifying the reservation type?

This one was intentionally put off for 2 reasons.
  1. We would have to change the syntax for resources. Current syntax is "name(role):value;...", how should we introduce the dynamic reservation there? perhaps "name[role]:value"? I mentioned this to Tim Chen and he suggested maybe we just ditch this and resort to a JSON format or something more explicit.
  2. I don't think we quite want to allow slave resources on the command line to include dynamic reservations. If we allow dynamic reservations to be specified here, we would have to explicitly check for this in the command line and maybe other places we want to disallow it.


> On Dec. 19, 2014, 2:05 a.m., Adam B wrote:
> > include/mesos/resources.hpp, lines 56-62
> > <https://reviews.apache.org/r/28698/diff/2/?file=793361#file793361line56>
> >
> >     So you expect that this will be called by something (e.g. checkpoint recovery) that already knows whether to interpret the strings as a static or dynamic reservation?

I added it because I thought it may be useful for tests, but we don't actually need it nor use it currently. I can remove it for now.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28698/#review65561
-----------------------------------------------------------


On Dec. 30, 2014, 2:44 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28698/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2014, 2:44 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Modified Resources to account for reservation type.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp f1517b73def9aff4039f95a89f66208ba1d21c0f 
>   src/common/resources.cpp c17e1791130e7d545bb7cdd54d97d65325d3a69e 
> 
> Diff: https://reviews.apache.org/r/28698/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Michael Park
> 
>


--===============1941298270215805737==--