Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 07B6E10CDE for ; Wed, 17 Dec 2014 23:25:50 +0000 (UTC) Received: (qmail 2992 invoked by uid 500); 17 Dec 2014 23:25:49 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 2924 invoked by uid 500); 17 Dec 2014 23:25:49 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 2908 invoked by uid 99); 17 Dec 2014 23:25:49 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Dec 2014 23:25:49 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id F29CE1D2466; Wed, 17 Dec 2014 23:25:48 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6920428618502559101==" MIME-Version: 1.0 Subject: Re: Review Request 28063: Introduced grace period in CommandInfo. From: "Alexander Rukletsov" To: "Niklas Nielsen" , "Till Toenshoff" , "Ben Mahler" Cc: "Mesos ReviewBot" , "mesos" , "Alexander Rukletsov" Date: Wed, 17 Dec 2014 23:25:48 -0000 Message-ID: <20141217232548.12942.3831@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Alexander Rukletsov" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/28063/ X-Sender: "Alexander Rukletsov" References: <20141124170726.15977.94209@reviews.apache.org> In-Reply-To: <20141124170726.15977.94209@reviews.apache.org> Reply-To: "Alexander Rukletsov" X-ReviewRequest-Repository: mesos-git --===============6920428618502559101== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28063/ ----------------------------------------------------------- (Updated Dec. 17, 2014, 11:25 p.m.) Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff. Changes ------- Minor change in comment. Bugs: MESOS-1571 https://issues.apache.org/jira/browse/MESOS-1571 Repository: mesos-git Description ------- CommandExecutor grace_period field is designed to be used by slave to propagate the value of the grace period flag further to containerizers and executors. Diffs (updated) ----- include/mesos/mesos.proto 0085aba src/slave/slave.hpp 70bd8c1 src/slave/slave.cpp ed63ded Diff: https://reviews.apache.org/r/28063/diff/ Testing ------- make check (Mac OS 10.9.4, Ubuntu 14.04) Thanks, Alexander Rukletsov --===============6920428618502559101==--