Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C34631007E for ; Tue, 16 Dec 2014 17:27:24 +0000 (UTC) Received: (qmail 39681 invoked by uid 500); 16 Dec 2014 17:27:24 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 39617 invoked by uid 500); 16 Dec 2014 17:27:24 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 39599 invoked by uid 99); 16 Dec 2014 17:27:23 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Dec 2014 17:27:23 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 75C541D210E; Tue, 16 Dec 2014 17:27:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0736560221230374938==" MIME-Version: 1.0 Subject: Re: Review Request 28966: PortMappingIsolator: added a metric to expose the number of TC IP filters on eth0. From: "Dominic Hamon" To: "Dominic Hamon" , "Jie Yu" , "Ian Downes" Cc: "mesos" , "Chi Zhang" Date: Tue, 16 Dec 2014 17:27:20 -0000 Message-ID: <20141216172720.12942.4399@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Dominic Hamon" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/28966/ X-Sender: "Dominic Hamon" References: <20141216015404.12935.75241@reviews.apache.org> In-Reply-To: <20141216015404.12935.75241@reviews.apache.org> Reply-To: "Dominic Hamon" X-ReviewRequest-Repository: mesos-git --===============0736560221230374938== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28966/#review65213 ----------------------------------------------------------- src/tests/port_mapping_tests.cpp this can be a const method as you don't change any members. - Dominic Hamon On Dec. 15, 2014, 5:54 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28966/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2014, 5:54 p.m.) > > > Review request for mesos, Dominic Hamon, Ian Downes, and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > also added a test. > > > Diffs > ----- > > src/slave/containerizer/isolators/network/port_mapping.hpp f1e2352 > src/slave/containerizer/isolators/network/port_mapping.cpp 2d81336 > src/tests/port_mapping_tests.cpp eb82993 > > Diff: https://reviews.apache.org/r/28966/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Chi Zhang > > --===============0736560221230374938==--