Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2A52910B3C for ; Thu, 11 Dec 2014 02:48:27 +0000 (UTC) Received: (qmail 88552 invoked by uid 500); 11 Dec 2014 02:48:26 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 88479 invoked by uid 500); 11 Dec 2014 02:48:26 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 88463 invoked by uid 99); 11 Dec 2014 02:48:26 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Dec 2014 02:48:26 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8F5D01D2346; Thu, 11 Dec 2014 02:48:23 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1500040601127449376==" MIME-Version: 1.0 Subject: Re: Review Request 28815: Converted an initial DRF integration test to a unit test. From: "Ben Mahler" To: "Jie Yu" Cc: "Dominic Hamon" , "Ben Mahler" , "mesos" Date: Thu, 11 Dec 2014 02:48:23 -0000 Message-ID: <20141211024823.5766.6048@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ben Mahler" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/28815/ X-Sender: "Ben Mahler" References: <20141208221039.5766.41540@reviews.apache.org> In-Reply-To: <20141208221039.5766.41540@reviews.apache.org> Reply-To: "Ben Mahler" X-ReviewRequest-Repository: mesos-git --===============1500040601127449376== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28815/ ----------------------------------------------------------- (Updated Dec. 11, 2014, 2:48 a.m.) Review request for mesos and Jie Yu. Changes ------- Removed SetUp / TearDown per Dominic's comment. Removed some dead includes per Jie's comments. Repository: mesos-git Description ------- Now that the allocator can be unit tested (r/28814), this adds the unit test base calss, and moves over the DRF test to a unit test. Diffs (updated) ----- src/Makefile.am 86161fe7a8bdd86958d24adb74d434cd92d7dfb8 src/tests/allocator_tests.cpp 8626362e5d45304a4800a807d5171178e457ff53 src/tests/hierarchical_allocator_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/28815/diff/ Testing ------- make check Thanks, Ben Mahler --===============1500040601127449376==--