Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1A0EDCB5B for ; Sat, 6 Dec 2014 02:04:36 +0000 (UTC) Received: (qmail 4236 invoked by uid 500); 6 Dec 2014 02:04:35 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 4161 invoked by uid 500); 6 Dec 2014 02:04:35 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 4145 invoked by uid 99); 6 Dec 2014 02:04:34 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 06 Dec 2014 02:04:34 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 886CE1D2294; Sat, 6 Dec 2014 02:04:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5505366671486470587==" MIME-Version: 1.0 Subject: Re: Review Request 28717: stout: Introduced getIP and created initialization wrappers for sockaddr_in and addrinfo From: "Ben Mahler" To: "Dominic Hamon" Cc: "Ben Mahler" , "mesos" , "Evelina Dumitrescu" Date: Sat, 06 Dec 2014 02:04:32 -0000 Message-ID: <20141206020432.32526.11490@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ben Mahler" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/28717/ X-Sender: "Ben Mahler" References: <20141205212608.32526.91514@reviews.apache.org> In-Reply-To: <20141205212608.32526.91514@reviews.apache.org> Reply-To: "Ben Mahler" X-ReviewRequest-Repository: mesos-git --===============5505366671486470587== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28717/#review64150 ----------------------------------------------------------- Great work Evelina! Just some minor code quality items below, could you or Dominic follow up with the fixes? Thank you! :) 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp Let's call this "result" :) 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp In general we avoid abbreviated names like "hints", and "results", which are _informative_ as to what they represent. :) 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp Ditto here. - Ben Mahler On Dec. 5, 2014, 9:26 p.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28717/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2014, 9:26 p.m.) > > > Review request for mesos and Dominic Hamon. > > > Bugs: MESOS-2178 > https://issues.apache.org/jira/browse/MESOS-2178 > > > Repository: mesos-git > > > Description > ------- > > Replaced obsolete functions gethostbyname2_r and gethostbyname2 with getaddrinfo and introduced getIP. > Created initialization wrappers for sockaddr_in and addrinfo > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp a992bd9f7caf3abcc2c5e14519ca7e3ac045bb4b > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp ec259cdee876c64f3e562aa77d4d52e964a173ab > > Diff: https://reviews.apache.org/r/28717/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Evelina Dumitrescu > > --===============5505366671486470587==--