Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F0A8610E4C for ; Thu, 4 Dec 2014 21:01:21 +0000 (UTC) Received: (qmail 87847 invoked by uid 500); 4 Dec 2014 21:01:21 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 87776 invoked by uid 500); 4 Dec 2014 21:01:21 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 87758 invoked by uid 99); 4 Dec 2014 21:01:20 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Dec 2014 21:01:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B9D8F1D2237; Thu, 4 Dec 2014 21:01:18 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7648369001940541699==" MIME-Version: 1.0 Subject: Re: Review Request 28322: Introduce libevent clock implementation. From: "Benjamin Hindman" To: "Niklas Nielsen" , "Benjamin Hindman" Cc: "Joris Van Remoortere" , "mesos" Date: Thu, 04 Dec 2014 21:01:18 -0000 Message-ID: <20141204210118.32526.7388@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Benjamin Hindman" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/28322/ X-Sender: "Benjamin Hindman" References: <20141203224842.32525.83045@reviews.apache.org> In-Reply-To: <20141203224842.32525.83045@reviews.apache.org> Reply-To: "Benjamin Hindman" X-ReviewRequest-Repository: mesos-git --===============7648369001940541699== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28322/#review63910 ----------------------------------------------------------- 3rdparty/libprocess/src/libevent.cpp See comments in previous review that added EventLoop::delay for libev. 3rdparty/libprocess/src/libevent.cpp Can this return an error? 3rdparty/libprocess/src/libevent.cpp Seconds seconds = Seconds(tval.tv_sec) + Microseconds(tval.tv_usec); return seconds.value(); 3rdparty/libprocess/src/libevent.cpp Can 'timer_ev' be NULL? Do we need to check? - Benjamin Hindman On Dec. 3, 2014, 10:48 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28322/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2014, 10:48 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/src/libevent.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/28322/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > > --===============7648369001940541699==--