Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 48F4910C43 for ; Mon, 1 Dec 2014 23:58:40 +0000 (UTC) Received: (qmail 41017 invoked by uid 500); 1 Dec 2014 23:58:40 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 40947 invoked by uid 500); 1 Dec 2014 23:58:40 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 40933 invoked by uid 99); 1 Dec 2014 23:58:39 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Dec 2014 23:58:39 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C9C601C0325; Mon, 1 Dec 2014 23:58:37 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3310470721362233840==" MIME-Version: 1.0 Subject: Re: Review Request 28365: Implemented protocol to update persistent resources between master and slave. From: "Vinod Kone" To: "Ben Mahler" , "Jie Yu" Cc: "Vinod Kone" , "mesos" Date: Mon, 01 Dec 2014 23:58:37 -0000 Message-ID: <20141201235837.32525.56804@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Vinod Kone" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/28365/ X-Sender: "Vinod Kone" References: <20141201182509.29132.58963@reviews.apache.org> In-Reply-To: <20141201182509.29132.58963@reviews.apache.org> Reply-To: "Vinod Kone" X-ReviewRequest-Repository: mesos-git --===============3310470721362233840== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28365/#review63460 ----------------------------------------------------------- src/master/master.cpp move this to ResourceUsageChecker() add duplicate disk id check to Resources::validate() src/master/master.cpp add a comment on why persistent resources cannot go empty or just always send it. src/master/master.cpp always send it. src/slave/slave.cpp just do a CHECK/EXIT instead. src/slave/slave.cpp gc released resources. - Vinod Kone On Dec. 1, 2014, 6:25 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28365/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2014, 6:25 p.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Added UpdatedResourcesMessage to inform slave about persistent resources. > > Slave informs about its persistent state during (re-)registration. > > > Diffs > ----- > > include/mesos/mesos.proto 0085aba923b53c37f31d5af30b2eeec5d533d8ba > include/mesos/resources.hpp 10777a62492e4a3333d764e0f75c064694e054d1 > src/common/resources.cpp 535a0eab6377b9ae63c960cdb05978647f667d5e > src/master/master.hpp 79b9ba720f343f512748211dd41ea7a0cfcb0cfb > src/master/master.cpp 8fcda4b9b5857f14cff8f6af2de31cca0208b88d > src/messages/messages.proto 28e593f338a154892b1cdf398710bb44e3f9f119 > src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6 > src/slave/slave.cpp ed63dedbda0bf548a95de7d39002ac56a29303e5 > > Diff: https://reviews.apache.org/r/28365/diff/ > > > Testing > ------- > > None. > > > Thanks, > > Vinod Kone > > --===============3310470721362233840==--