-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29437/#review66448
-----------------------------------------------------------
Patch looks great!
Reviews applied: [29437]
All tests passed.
- Mesos ReviewBot
On Dec. 31, 2014, 5:11 a.m., Nishant Suneja wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29437/
> -----------------------------------------------------------
>
> (Updated Dec. 31, 2014, 5:11 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-999
> https://issues.apache.org/jira/browse/MESOS-999
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> As part of this bug fix, I have trigerred the executor registration timeout timer asychronously,
> when the onAny() callback is made for the container's future object, instead of starting
the
> timer synchronously when the launchExecutor() method of the Framework class is invoked.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
> src/tests/composing_containerizer_tests.cpp 5ab5a36cadb7f8622bad0c5814e9a5fb338753ad
> src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
> src/tests/slave_tests.cpp f2896a1fc4521452e29fd261a6f117372345dcfc
>
> Diff: https://reviews.apache.org/r/29437/diff/
>
>
> Testing
> -------
>
> Added the unit test : SlaveTest::AsynchronousExecutorRegistrationTimeoutTrigger
> make check succeeds.
>
>
> Thanks,
>
> Nishant Suneja
>
>
|