mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 28697: Add ReservationType and ReservationInfo for dynamic reservations.
Date Tue, 30 Dec 2014 20:43:24 GMT


> On Dec. 18, 2014, 10:43 p.m., Adam B wrote:
> > include/mesos/mesos.proto, lines 402-404
> > <https://reviews.apache.org/r/28697/diff/2/?file=793360#file793360line402>
> >
> >     Framework writers will definitely need more documentation than this about dynamic
reservations. Probably worth a separate subtask and review for a docs/reservations.md
> 
> Michael Park wrote:
>     Are framework writers expected to (or already does) use `<include/mesos/mesos.proto>`
as documentation? Does it suffice to add the `docs/reservations.md`? or should I modify this
comment to be more detailed as well?

Added a JIRA ticket to track this: https://issues.apache.org/jira/browse/MESOS-2205


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28697/#review65519
-----------------------------------------------------------


On Dec. 30, 2014, 8:42 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28697/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2014, 8:42 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-2137
>     https://issues.apache.org/jira/browse/MESOS-2137
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Adding new protobuf messages necessary to support dynamic reservations.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437 
> 
> Diff: https://reviews.apache.org/r/28697/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message