mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 28218: Add more logging into replicated log recovery.
Date Wed, 24 Dec 2014 22:37:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28218/#review66059
-----------------------------------------------------------


Patch looks great!

Reviews applied: [28218]

All tests passed.

- Mesos ReviewBot


On Dec. 24, 2014, 10:09 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28218/
> -----------------------------------------------------------
> 
> (Updated Dec. 24, 2014, 10:09 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> There has a quite few cases where we see a timed out fetch when master is first launched,
and I think there isn't enough logging to shed some lights besides the failed to fetch after
x minutes log line.
> This rb adds more logging into replicated log recovery.
> Not meant for merging yet, posting here for reviews and discuss places we like to add
more logging.
> Review: https://reviews.apache.org/r/28218
> 
> 
> Diffs
> -----
> 
>   src/log/log.cpp b3c6c20d734ea82d8531217d53decf1707183565 
>   src/log/recover.cpp 26140654fda5011e89d0081e916a88c9681cd783 
>   src/log/replica.cpp c18de86f2659b848b0e8f0468e4efa820d048970 
>   src/state/log.cpp c0c81d551f465534daeaf03f18c0baa4c19754e6 
> 
> Diff: https://reviews.apache.org/r/28218/diff/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message