mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 28063: Introduced grace period in CommandInfo.
Date Wed, 24 Dec 2014 09:20:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28063/#review66019
-----------------------------------------------------------



include/mesos/mesos.proto
<https://reviews.apache.org/r/28063/#comment109368>

    grace_period_seconds? To make the unit explicit
    Is there a default, or does it default to None?



src/slave/slave.hpp
<https://reviews.apache.org/r/28063/#comment109369>

    private?



src/slave/slave.cpp
<https://reviews.apache.org/r/28063/#comment109372>

    I feel like 'setGracePeriod' is inaccurate if it doesn't always set it (when already set).
Maybe 'updateGracePeriod' or 'enforceGracePeriod' or 'mergeGracePeriod'? You can probably
come up with something better.



src/slave/slave.cpp
<https://reviews.apache.org/r/28063/#comment109371>

    Why not take `flags` as a parameter too? Then setGracePeriod(task, flags) or setGracePeriod(task,
grace_period) could be a static method that doesn't even need to live on `Slave`.



src/slave/slave.cpp
<https://reviews.apache.org/r/28063/#comment109370>

    There should only be one CommandInfo to modify, so you can use a CHECK or make this an
if/else


- Adam B


On Dec. 23, 2014, 7:25 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28063/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2014, 7:25 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
> 
> 
> Bugs: MESOS-1571
>     https://issues.apache.org/jira/browse/MESOS-1571
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> CommandExecutor grace_period field is designed to be used by slave to propagate the value
of the grace period flag further to containerizers and executors.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 0085aba 
>   src/slave/slave.hpp 70bd8c1 
>   src/slave/slave.cpp ed63ded 
> 
> Diff: https://reviews.apache.org/r/28063/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS 10.9.4, Ubuntu 14.04)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message