mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Evelina Dumitrescu" <evelina.a.dumitre...@gmail.com>
Subject Re: Review Request 29288: stout: Created IP address abstraction for different protocol families
Date Sat, 20 Dec 2014 03:38:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29288/
-----------------------------------------------------------

(Updated Dec. 20, 2014, 3:38 a.m.)


Review request for mesos and Dominic Hamon.


Bugs: MESOS-1919
    https://issues.apache.org/jira/browse/MESOS-1919


Repository: mesos-git


Description
-------

Created the inner class Address encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
The Address can be in NETWORK or BYTE order.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but
write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing
of the protocol headers differ.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 80578e2207d5436a4414f56417a0fee06ca9a7e9

  3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp 425132e5d7c3770be4a5a39feea5a2f22179b871


Diff: https://reviews.apache.org/r/29288/diff/


Testing
-------

make check


Thanks,

Evelina Dumitrescu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message