mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kapil Arya" <ka...@mesosphere.io>
Subject Re: Review Request 28655: [WIP] Added Master hook for adding task labels
Date Thu, 18 Dec 2014 00:35:03 GMT


> On Dec. 17, 2014, 7:06 p.m., Till Toenshoff wrote:
> > src/Makefile.am, line 269
> > <https://reviews.apache.org/r/28655/diff/3/?file=789854#file789854line269>
> >
> >     I would try to adhere more towards the backslash spacing as used by e.g. "logging/logging.hpp"
and fix the others in this section (at least). AFAIK for Makefile.am we use 8 char hard-tabs.

Not sure what you mean by this. I was using tabs only. In any case, fixed some more space
issues in the newest diff.


> On Dec. 17, 2014, 7:06 p.m., Till Toenshoff wrote:
> > src/hook/manager.cpp, lines 64-67
> > <https://reviews.apache.org/r/28655/diff/3/?file=789857#file789857line64>
> >
> >     Is this going to be a growing list of checks for specific hook modules and add
them to the respective hook interfaces?

Yes.  It should be easy to update if we can come up with a better scheme.


- Kapil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28655/#review65388
-----------------------------------------------------------


On Dec. 17, 2014, 7:32 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28655/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2014, 7:32 p.m.)
> 
> 
> Review request for mesos and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This hook allows hook modules to add additional labels to the incoming TaskInfo object.
 The labels are then read on the slave/executor side which may then act upon them.
> 
> TODOs before we commit:
> 0. Split this RR to move Master specific code to a separate RR.
> 1. Add a test hook module.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 86161fe7a8bdd86958d24adb74d434cd92d7dfb8 
>   src/hook/hook.hpp PRE-CREATION 
>   src/hook/manager.hpp PRE-CREATION 
>   src/hook/manager.cpp PRE-CREATION 
>   src/master/flags.hpp 1cea50c02f3ad7de1e1ae91d65d1accdb9af7b03 
>   src/master/main.cpp 193d53f13d8b14638b311cc290b5a5802ea56299 
>   src/master/master.cpp 1cf2074b78e260bcccf96f4383bc4747b1e75063 
>   src/module/hook.hpp PRE-CREATION 
>   src/module/manager.cpp b15b0fc3f056fe29bd4d1acca508d75805ef2e0b 
> 
> Diff: https://reviews.apache.org/r/28655/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message