mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 29083: Updated Sorter to allow transforming allocated resources.
Date Wed, 17 Dec 2014 23:20:09 GMT


> On Dec. 16, 2014, 5:23 p.m., Dominic Hamon wrote:
> > src/master/drf_sorter.cpp, line 125
> > <https://reviews.apache.org/r/29083/diff/1/?file=792872#file792872line125>
> >
> >     const_iterator

This was originally copied from the other code in here, but now it's not relevant anymore.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29083/#review65210
-----------------------------------------------------------


On Dec. 16, 2014, 6:28 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29083/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2014, 6:28 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-2099
>     https://issues.apache.org/jira/browse/MESOS-2099
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> In order for frameworks to perform resource transformations on their allocations, the
allocator must be able to update the allocation in the sorter objects.
> 
> Note that the sorters cannot simply take a Transformation, as done in r/29084/. This
is because sorters may not store the complete allocation for a client (e.g. role sorter doesn't
track reserved resources).
> 
> This means that taking a Transformation is problematic for the role sorter in the allocator.
> 
> 
> Diffs
> -----
> 
>   src/master/drf_sorter.hpp c47b56afdb8f9f3ff0793f0d10a4e4c656e6a212 
>   src/master/drf_sorter.cpp 0ad6c52759e1ceec4b43f99d8fa1e75d7e2e1c31 
>   src/master/sorter.hpp 0150f90b9aab2ecb4edd07dca7f0d58997e422aa 
>   src/tests/sorter_tests.cpp 0516ab573d9f4f2af249978e15ebf52c2afb5359 
> 
> Diff: https://reviews.apache.org/r/29083/diff/
> 
> 
> Testing
> -------
> 
> Added a test.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message