mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 28815: Converted an initial DRF integration test to a unit test.
Date Wed, 17 Dec 2014 01:29:04 GMT


> On Dec. 16, 2014, 10:14 p.m., Benjamin Hindman wrote:
> > src/tests/hierarchical_allocator_tests.cpp, line 173
> > <https://reviews.apache.org/r/28815/diff/2/?file=788971#file788971line173>
> >
> >     This breaks on my Linux box with gcc 4.4.7.
> >     
> >     $ uname -a
> >     Linux centos6-build 2.6.32-431.23.3.el6.x86_64 #1 SMP Thu Jul 31 17:20:51 UTC
2014 x86_64 x86_64 x86_64 GNU/Linux
> >     
> >     $ gcc --version
> >     gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-11)
> >     Copyright (C) 2010 Free Software Foundation, Inc.
> >     This is free software; see the source for copying conditions.  There is NO
> >     warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Fixed, thanks for sending me the patch!


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28815/#review65250
-----------------------------------------------------------


On Dec. 11, 2014, 2:48 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28815/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2014, 2:48 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Now that the allocator can be unit tested (r/28814), this adds the unit test base calss,
and moves over the DRF test to a unit test.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 86161fe7a8bdd86958d24adb74d434cd92d7dfb8 
>   src/tests/allocator_tests.cpp 8626362e5d45304a4800a807d5171178e457ff53 
>   src/tests/hierarchical_allocator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/28815/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message