mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 28698: [WIP] Modified Resources to account for reservation type.
Date Tue, 16 Dec 2014 23:52:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28698/#review65258
-----------------------------------------------------------



src/common/resources.cpp
<https://reviews.apache.org/r/28698/#comment108330>

    What should be the default behaviour for functions like `reserved(role)`?
      1. Return resources with the same role, ignoring reservations, or
      2. Return resources with the same role and set reservation to be STATIC by default.
    
    I've implemented 1 here because I believe it's a better API but I'm wondering if it has
backwards-compatibility issues.


- Michael Park


On Dec. 16, 2014, 11:04 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28698/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2014, 11:04 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Modified Resources to account for reservation type.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp 296553af93ec8457dad04ac018f03f36df654fdc 
>   src/common/resources.cpp 9bf7ae9148d6db2829cc2866ac048fe018ae2c92 
> 
> Diff: https://reviews.apache.org/r/28698/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message