mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 29088: Removed an unnecessary helper in the sorter tests.
Date Tue, 16 Dec 2014 18:16:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29088/#review65217
-----------------------------------------------------------

Ship it!



src/tests/sorter_tests.cpp
<https://reviews.apache.org/r/29088/#comment108252>

    Curious if the following will compile or not:
    
    EXPECT_EQ(sorter.sort(), {"a", "b"});


- Jie Yu


On Dec. 16, 2014, 6:28 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29088/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2014, 6:28 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This helper is no longer necessary, and the EXPECT statments inside a method loses line
number information when the tests fail.
> 
> 
> Diffs
> -----
> 
>   src/tests/sorter_tests.cpp 0516ab573d9f4f2af249978e15ebf52c2afb5359 
> 
> Diff: https://reviews.apache.org/r/29088/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message