mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Downes" <ian.dow...@gmail.com>
Subject Re: Review Request 29033: PortMappingIsolator: added metrics for the numbers of active and TIME_WAIT tcp connections.
Date Mon, 15 Dec 2014 18:45:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29033/#review65099
-----------------------------------------------------------



src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/29033/#comment108047>

    Can you assume the output format stable? does it depend on anything, e.g., if ipv6 is
enabled?
    
    Can you add a note here why reading `/proc/net/sockstat` is not expensive.



src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/29033/#comment108050>

    what about continuing if !startsWith(line, "TCP") to reduce the nesting?



src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/29033/#comment108051>

    what about splitting on the ":" since that denotes the differences between lines



src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/29033/#comment108045>

    kill newline



src/tests/port_mapping_tests.cpp
<https://reviews.apache.org/r/29033/#comment108053>

    you should be able to at least check for an active tcp connection as well?


- Ian Downes


On Dec. 14, 2014, 7:26 p.m., Chi Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29033/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2014, 7:26 p.m.)
> 
> 
> Review request for mesos, Dominic Hamon, Ian Downes, Jie Yu, and Cong Wang.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> While we are still working to make RTT less expensive to get, expose total number of
tcp connections in use and in TIME_WAIT. 
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 540071d 
>   src/slave/containerizer/isolators/network/port_mapping.hpp f1e2352 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 2d81336 
>   src/slave/flags.hpp 670997d 
>   src/tests/port_mapping_tests.cpp eb82993 
> 
> Diff: https://reviews.apache.org/r/29033/diff/
> 
> 
> Testing
> -------
> 
> expanded a test case to test PortMappingStatistics.
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message