mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dominic Hamon" <dha...@twopensource.com>
Subject Re: Review Request 28983: Added multiplication and division operators for Bytes.
Date Fri, 12 Dec 2014 17:02:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28983/#review64924
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/bytes.hpp
<https://reviews.apache.org/r/28983/#comment107761>

    what happens if someone passes in a negative multiplier?


- Dominic Hamon


On Dec. 11, 2014, 11:21 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28983/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2014, 11:21 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Discovered these were missing when trying to unit test the allocator.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/bytes.hpp 72dea4d27ae57ab924de9afc3ce6b154618a54fd

> 
> Diff: https://reviews.apache.org/r/28983/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> Added tests in the subsequent review.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message