mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 28904: echo command in sh doesn't have options
Date Wed, 10 Dec 2014 16:31:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28904/#review64561
-----------------------------------------------------------


Patch looks great!

Reviews applied: [28904]

All tests passed.

- Mesos ReviewBot


On Dec. 10, 2014, 3:45 p.m., Kiyonari Harigae wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28904/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2014, 3:45 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> echo command in sh doesn't have options
> 
> sh: echo: I/O error occurs, It is not possible to set the port range.
> Also, echo in /bin/sh performs output a (horizontal) tab character
> when encountered the escape sequence of \t.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolators/network/port_mapping.cpp c6fff21903e546709a90b53690e02a75a4ca5262

> 
> Diff: https://reviews.apache.org/r/28904/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kiyonari Harigae
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message