mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niklas Nielsen" <...@qni.dk>
Subject Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.
Date Sat, 06 Dec 2014 00:05:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27760/#review64116
-----------------------------------------------------------

Ship it!



src/authentication/authenticator.hpp
<https://reviews.apache.org/r/27760/#comment106566>

    s/clientPid/pid/g?



src/authentication/cram_md5/authenticator.hpp
<https://reviews.apache.org/r/27760/#comment106567>

    Why was this not a problem before? I don't see size_t in your review elsewhere?



src/authentication/cram_md5/authenticator.hpp
<https://reviews.apache.org/r/27760/#comment106555>

    s/clientPid/pid/?



src/authentication/cram_md5/authenticator.hpp
<https://reviews.apache.org/r/27760/#comment106556>

    Why can we remove this?



src/master/master.cpp
<https://reviews.apache.org/r/27760/#comment106563>

    Wrap around '=' and bring lines down to 4 spaces.
    This can be const too, right?



src/master/master.cpp
<https://reviews.apache.org/r/27760/#comment106564>

    How about capturing this in the log message too?



src/master/master.cpp
<https://reviews.apache.org/r/27760/#comment106554>

    Wrap around '=' and 4 space indent


- Niklas Nielsen


On Nov. 17, 2014, 5:13 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27760/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2014, 5:13 p.m.)
> 
> 
> Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Vinod Kone.
> 
> 
> Bugs: MESOS-2050
>     https://issues.apache.org/jira/browse/MESOS-2050
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> The initial design and implementation of the authenticator module interface caused issues
and was not optimal for heavy lifting setup of external dependencies. By introducing a two
fold design, this has been decoupled from the authentication message processing. The new design
also gets us back on track to the goal of makeing SASL a soft dependency of mesos.
> 
> 
> Diffs
> -----
> 
>   src/authentication/authenticator.hpp 460494a 
>   src/authentication/cram_md5/authenticator.hpp d739a02 
>   src/master/master.hpp ece36c3 
>   src/master/master.cpp b5fa8d1 
>   src/tests/cram_md5_authentication_tests.cpp a356aa1 
> 
> Diff: https://reviews.apache.org/r/27760/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message