mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 28719: libprocess: Introduced getIP and created initialization wrappers for sockaddr_in and addrinfo
Date Fri, 05 Dec 2014 22:08:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28719/#review64095
-----------------------------------------------------------


Patch looks great!

Reviews applied: [28716, 28717, 28718, 28719]

All tests passed.

- Mesos ReviewBot


On Dec. 5, 2014, 9:26 p.m., Evelina Dumitrescu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28719/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2014, 9:26 p.m.)
> 
> 
> Review request for mesos and Dominic Hamon.
> 
> 
> Bugs: MESOS-2178
>     https://issues.apache.org/jira/browse/MESOS-2178
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Replaced obsolete functions gethostbyname2_r and gethostbyname2 with getaddrinfo and
introduced getIP.
> Created initialization wrappers for sockaddr_in and addrinfo
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/socket.hpp ab080c154095029c4a01d189a5fd8a178ba6c92e

>   3rdparty/libprocess/src/pid.cpp a2c620ef0858ee03ca6d20264125f2c254697078 
>   3rdparty/libprocess/src/process.cpp 4db7d56af710577e08a9d7dbeb92a1f01559401f 
> 
> Diff: https://reviews.apache.org/r/28719/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Evelina Dumitrescu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message