mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Evelina Dumitrescu" <evelina.a.dumitre...@gmail.com>
Subject Re: Review Request 28716: Created accept, bind, connect and getsockname wrappers for different protocol families
Date Fri, 05 Dec 2014 20:33:47 GMT


> On Dec. 5, 2014, 5:34 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/src/net.hpp, line 49
> > <https://reviews.apache.org/r/28716/diff/5/?file=783794#file783794line49>
> >
> >     that += seems weird.
> >     
> >     this should be:
> >     
> >         throw runtime_error("socket: " + trySocket.error());
> >         
> >     i think!

asked benh for more insight about the problem with the dead code.


- Evelina


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28716/#review64017
-----------------------------------------------------------


On Dec. 5, 2014, 8:31 p.m., Evelina Dumitrescu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28716/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2014, 8:31 p.m.)
> 
> 
> Review request for mesos and Dominic Hamon.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Created accept, bind, connect and getsockname wrappers in socket.hpp for different protocol
families
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/socket.hpp ab080c154095029c4a01d189a5fd8a178ba6c92e

>   3rdparty/libprocess/src/http.cpp b00f33339366f5c06b6f20e38c5ae0c23b8a9358 
>   3rdparty/libprocess/src/process.cpp 4db7d56af710577e08a9d7dbeb92a1f01559401f 
>   3rdparty/libprocess/src/tests/http_tests.cpp a90e65f77904da0a45e1cc0cc9889ae69354a1a5

>   3rdparty/libprocess/src/tests/process_tests.cpp dec62e88ec993433e1a0777593bb2657b43636dc

> 
> Diff: https://reviews.apache.org/r/28716/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Evelina Dumitrescu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message